🧹 [code health] Extract HTTP status magic numbers to constants in github.ts

src/lib/__tests__/github/fetchRepositories.test.ts

@@ -19,6 +19,36 @@ describe("fetchRepositories", () => {
     expect(result.languages[1].bytes).toBe(5000);
   });
 
+  it("GraphQL query fails when forbidden due to bad token", async () => {
+    // If token is missing, fetchRepositories doesn't throw, it falls back to REST API.
+    // What about an invalid token format?
+    const { headers } = await import("../../github");
+    const { GitHubApiError } = await import("../../types");
+    expect(() => headers("invalid token format!!")).toThrow(GitHubApiError);
+  });
+
+  it("GraphQL API throws RateLimitError on 403 response", async () => {
+    mockFetch.mockResolvedValueOnce(jsonResponse({ message: "API rate limit exceeded" }, 403, { "X-RateLimit-Reset": "1700000000" }));
+    const { fetchRepositories } = await import("../../github");
+    const { RateLimitError } = await import("../../types");
+    await expect(fetchRepositories("testuser", "fake-token")).rejects.toThrow(RateLimitError);
+  });
+
+  it("GraphQL API with invalid token throws BAD_REQUEST", async () => {
+    // If token is missing, fetchRepositories doesn't throw, it falls back to REST API.
+    // What about an invalid token format?
+    const { fetchRepositories } = await import("../../github");
+    const { GitHubApiError } = await import("../../types");
+    await expect(fetchRepositories("testuser", "invalid token format!!")).rejects.toThrow(GitHubApiError);
+  });
+
+  it("GraphQL API throws GitHubApiError on 401 response", async () => {
+    mockFetch.mockResolvedValueOnce(jsonResponse({ message: "Bad credentials" }, 401));
+    const { fetchRepositories } = await import("../../github");
+    const { GitHubApiError } = await import("../../types");
+    await expect(fetchRepositories("testuser", "fake-token")).rejects.toThrow(GitHubApiError);
+  });
+
   it("GraphQL レスポンスからトピックを正しく集計する", async () => {
     mockFetch.mockResolvedValueOnce(jsonResponse(MOCK_REPOS_GRAPHQL));
 
@@ -92,4 +122,5 @@ describe("fetchRepositories", () => {
       UserNotFoundError
     );
   });
+
 });

src/lib/__tests__/github/fetchUserProfile.test.ts

@@ -12,6 +12,31 @@ describe("fetchUserProfile", () => {
       expect(e).toBeInstanceOf(RateLimitError);
     }
   });
+
+  it("GraphQL API without token throws UNAUTHORIZED correctly through API error", async () => {
+    const { fetchContributions } = await import("../../github");
+    const { GitHubApiError } = await import("../../types");
+    await expect(fetchContributions("testuser")).rejects.toThrow(GitHubApiError);
+  });
+
+  it("HTTP_STATUS object contains correct status codes", async () => {
+    const { HTTP_STATUS } = await import("../../github");
+    expect(HTTP_STATUS.BAD_REQUEST).toBe(400);
+    expect(HTTP_STATUS.UNAUTHORIZED).toBe(401);
+    expect(HTTP_STATUS.FORBIDDEN).toBe(403);
+    expect(HTTP_STATUS.NOT_FOUND).toBe(404);
+  });
+
+
+
+  it("無効なトークンフォーマットの場合 GitHubApiError をスローする", async () => {
+    const { fetchUserProfile } = await import("../../github");
+    const { GitHubApiError } = await import("../../types");
+
+    await expect(fetchUserProfile("testuser", "invalid token with spaces")).rejects.toThrow(
+      GitHubApiError
+    );
+  });
   it("プロフィール・組織・ピン留めを正しく取得して結合する", async () => {
     mockFetch
       .mockResolvedValueOnce(jsonResponse(MOCK_USER))                    // GET /users/testuser

src/lib/github.ts

@@ -24,14 +24,22 @@ import {
 const GITHUB_API = "https://api.github.com";
 const GITHUB_GRAPHQL = "https://api.github.com/graphql";
 
+export const HTTP_STATUS = {
+  BAD_REQUEST: 400,
+  UNAUTHORIZED: 401,
+  FORBIDDEN: 403,
+  NOT_FOUND: 404,
+} as const;
+
+
 export function headers(token?: string): HeadersInit {
   const h: HeadersInit = {
     Accept: "application/vnd.github+json",
     "User-Agent": "github-user-summary",
   };
   if (token) {
     if (!/^[A-Za-z0-9_=-]+$/.test(token)) {
-      throw new GitHubApiError("Invalid token format", 400);
+      throw new GitHubApiError("Invalid token format", HTTP_STATUS.BAD_REQUEST);
     }
     h.Authorization = `Bearer ${token}`;
   }
@@ -45,10 +53,10 @@ export function handleRateLimit(res: Response): never {
 }
 
 async function handleResponse<T>(res: Response): Promise<T> {
-  if (res.status === 404) {
+  if (res.status === HTTP_STATUS.NOT_FOUND) {
     throw new UserNotFoundError("unknown");
   }
-  if (res.status === 403) {
+  if (res.status === HTTP_STATUS.FORBIDDEN) {
     handleRateLimit(res);
   }
   if (!res.ok) {
@@ -106,10 +114,7 @@ function calculateMostActiveDay(calendar: { date: string; count: number }[]): st
     : "";
 }
 
-async function graphql<T>(query: string, token?: string, variables?: Record<string, unknown>): Promise<T> {
-  if (!token) {
-    throw new GitHubApiError("GraphQL API requires authentication token", 401);
-  }
+async function graphql<T>(query: string, token: string, variables?: Record<string, unknown>): Promise<T> {
   const body: { query: string; variables?: Record<string, unknown> } = { query };
   if (variables) {
     body.variables = variables;
@@ -121,7 +126,7 @@ async function graphql<T>(query: string, token?: string, variables?: Record<stri
     body: JSON.stringify(body),
     next: { revalidate: 300 },
   });
-  if (res.status === 403) {
+  if (res.status === HTTP_STATUS.FORBIDDEN) {
     handleRateLimit(res);
   }
   if (!res.ok) {
@@ -499,7 +504,7 @@ export async function fetchContributions(
 ): Promise<ContributionData> {
   if (!token) {
     // GraphQL 必須なので、token なしの場合はデフォルト値を返す
-    throw new GitHubApiError("Contributions data requires authentication", 401);
+    throw new GitHubApiError("Contributions data requires authentication", HTTP_STATUS.UNAUTHORIZED);
   }
 
   const now = new Date();