🧹 [refactor: extract graphQL fragment and deep nested loop logic]#352
🧹 [refactor: extract graphQL fragment and deep nested loop logic]#352is0692vs wants to merge 1 commit into
Conversation
Co-authored-by: is0692vs <135803462+is0692vs@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
More reviews will be available in 52 minutes and 30 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors src/lib/githubYearInReview.ts by extracting helper functions buildRepoFragment and extractCommitDatesFromRepo to modularize GraphQL query fragment construction and commit date extraction. Feedback suggests improving type safety and readability in extractCommitDatesFromRepo by defining a dedicated interface for the GraphQL response and utilizing optional chaining instead of repetitive type assertions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| function extractCommitDatesFromRepo(repoData: Record<string, unknown> | undefined): string[] { | ||
| const dates: string[] = []; | ||
| const defaultBranchRef = repoData?.defaultBranchRef as Record<string, unknown> | undefined; | ||
| const target = defaultBranchRef?.target as Record<string, unknown> | undefined; | ||
| const history = target?.history as Record<string, unknown> | undefined; | ||
| const historyNodes = (history?.nodes as Array<Record<string, unknown>> | undefined) || []; | ||
| for (const node of historyNodes) { | ||
| const author = node?.author as Record<string, unknown> | undefined; | ||
| if (typeof author?.date === 'string') { | ||
| dates.push(author.date); | ||
| } | ||
| } | ||
| return dates; | ||
| } |
There was a problem hiding this comment.
The current implementation of extractCommitDatesFromRepo relies on repetitive type assertions (as Record<string, unknown> | undefined) to traverse the nested GraphQL response. This is verbose, hard to maintain, and bypasses TypeScript's type safety.
By defining a dedicated interface for the expected GraphQL response structure and leveraging optional chaining alongside Array.isArray, we can make the extraction process much cleaner, safer, and more robust. Additionally, ensure that we maintain explicit return types for functions to ensure type safety and API clarity.
interface RepoCommitHistory {
defaultBranchRef?: {
target?: {
history?: {
nodes?: Array<{
author?: {
date?: string;
};
}>;
};
};
};
}
function extractCommitDatesFromRepo(repoData: unknown): string[] {
const dates: string[] = [];
const nodes = (repoData as RepoCommitHistory | undefined)?.defaultBranchRef?.target?.history?.nodes;
if (Array.isArray(nodes)) {
for (const node of nodes) {
const date = node?.author?.date;
if (typeof date === 'string') {
dates.push(date);
}
}
}
return dates;
}References
- Maintain explicit return types for functions in TypeScript to ensure type safety and API clarity.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| return top; | ||
| } | ||
|
|
||
|
|
||
| function buildRepoFragment(index: number): string { |
There was a problem hiding this comment.
| return top; | |
| } | |
| function buildRepoFragment(index: number): string { | |
| return top; | |
| } | |
| function buildRepoFragment(index: number): string { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/lib/githubYearInReview.ts
Line: 139-143
Comment:
関数間の空行が2行連続になっています。通常のTypeScriptスタイルでは関数間は1行のみの空行が一般的です。
```suggestion
return top;
}
function buildRepoFragment(index: number): string {
```
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| function extractCommitDatesFromRepo(repoData: Record<string, unknown> | undefined): string[] { | ||
| const dates: string[] = []; | ||
| const defaultBranchRef = repoData?.defaultBranchRef as Record<string, unknown> | undefined; | ||
| const target = defaultBranchRef?.target as Record<string, unknown> | undefined; | ||
| const history = target?.history as Record<string, unknown> | undefined; | ||
| const historyNodes = (history?.nodes as Array<Record<string, unknown>> | undefined) || []; | ||
| for (const node of historyNodes) { | ||
| const author = node?.author as Record<string, unknown> | undefined; | ||
| if (typeof author?.date === 'string') { | ||
| dates.push(author.date); | ||
| } | ||
| } | ||
| return dates; | ||
| } |
There was a problem hiding this comment.
PRの説明に「Added verification of extraction via tests」とありますが、差分に新しいテストファイルが含まれていません。buildRepoFragment と extractCommitDatesFromRepo はいずれも非公開関数のため、既存の fetchCommitDatesForTopRepos の統合テスト経由でしか検証されません。抽出したロジックの境界値（repoData が undefined、nodes が空配列、date フィールドが文字列以外の型など）を直接カバーするユニットテストを追加することで、将来の改修時の安全性が高まります。
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/lib/githubYearInReview.ts
Line: 163-176
Comment:
**抽出関数の単体テストが見当たらない**
PRの説明に「Added verification of extraction via tests」とありますが、差分に新しいテストファイルが含まれていません。`buildRepoFragment` と `extractCommitDatesFromRepo` はいずれも非公開関数のため、既存の `fetchCommitDatesForTopRepos` の統合テスト経由でしか検証されません。抽出したロジックの境界値（`repoData` が `undefined`、`nodes` が空配列、`date` フィールドが文字列以外の型など）を直接カバーするユニットテストを追加することで、将来の改修時の安全性が高まります。
How can I resolve this? If you propose a fix, please make it concise.1 participant
🎯 What: The code health issue addressed
Deep nesting and repetitive logic within
fetchCommitDatesForTopReposinsrc/lib/githubYearInReview.ts. The GraphQL repository fragment construction and deep loop structure for parsing dates were deeply nested.💡 Why: How this improves maintainability
Extracting the fragment building (
buildRepoFragment) and date extraction (extractCommitDatesFromRepo) functions significantly flattens the execution logic offetchCommitDatesForTopRepos. The code is simpler to read and less prone to logical errors introduced by deep block scopes. It reduces cognitive complexity in the try-catch block.✅ Verification: How you confirmed the change is safe
npm run lintwhich resulted in 0 errors (only existing image warnings).npm run testvalidating all 551 tests pass, including thesrc/lib/__tests__/githubYearInReview.test.tssuite.npx tsc --noEmitlocally with no typing errors.✨ Result: The improvement achieved
Reduced deep indentation and nested logic within the core GraphQL query construction and processing loop of
fetchCommitDatesForTopRepos, leading to cleaner, more maintainable code without behavioral changes.PR created automatically by Jules for task 561608437437787364 started by @is0692vs
Greptile Summary
深くネストされていた
fetchCommitDatesForTopRepos内のGraphQLフラグメント生成ロジックとコミット日付抽出ループを、それぞれbuildRepoFragment/extractCommitDatesFromRepoとして抽出した純粋なリファクタリングです。挙動の変更は一切なく、既存の551件のテストも全てパスしています。buildRepoFragment(index)を抽出することでクエリ構築部分のインデントが平坦化され、可読性が向上しました。extractCommitDatesFromRepo(repoData)を抽出することでtryブロック内のネストが削減され、dates.push(...repoDates)という簡潔な1行に置き換えられました。Confidence Score: 4/5
挙動変更のない純粋なリファクタリングであり、マージは安全です。
抽出された2つのヘルパー関数のロジックは元のインラインコードと完全に同一で、破壊的変更はありません。関数間の余分な空行と、抽出ロジックに対する専用ユニットテストが存在しない点が軽微な品質上の指摘として残ります。
特に注意が必要なファイルはありません。
src/lib/githubYearInReview.tsのみの変更で、変更内容はシンプルです。Important Files Changed
buildRepoFragment/extractCommitDatesFromRepoとして抽出。ロジックは元のインラインコードと完全に同一で挙動の変化はなし。連続した空行（141行目付近）がスタイル上の軽微な問題として残る。Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["fetchCommitDatesForTopRepos()"] --> B["候補リポジトリをフィルタ・ソート（上位4件）"] B --> C{"candidates.length === 0?"} C -- Yes --> D["return []"] C -- No --> E["candidates.forEach(index)"] E --> F["buildRepoFragment(index)\n→ GraphQL fragment 文字列を生成"] E --> G["variables に owner/name をセット"] F & G --> H["variableDefs / query を組み立て"] H --> I["graphql(query, token, variables) を実行"] I --> J{"成功?"} J -- No --> K["logger.error\nreturn []"] J -- Yes --> L["candidates をループ (i=0..n)"] L --> M["extractCommitDatesFromRepo(repoData)\n→ date 文字列配列を返す"] M --> N["dates に spread して追加"] N --> O["return dates"]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "refactor: extract graphQL fragment and d..." | Re-trigger Greptile