Skip to content

🧹 [code health improvement] Use logger instead of console.warn in useThemeColor.ts #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
is0692vs wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

🧹 [code health improvement] Use logger instead of console.warn in useThemeColor.ts #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hooks/__tests__/useThemeColor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { renderHook, waitFor } from "@testing-library/react";
import { useThemeColor } from "../useThemeColor";
import * as colorLib from "@/lib/color";
import { FastAverageColor } from "fast-average-color";
import { logger } from "@/lib/logger";

// Mock fast-average-color
vi.mock("fast-average-color", () => {
Expand Down Expand Up @@ -54,8 +55,8 @@ describe("useThemeColor", () => {
value: [100, 150, 200, 255]
});

// Suppress console.warn for error tests
vi.spyOn(console, "warn").mockImplementation(() => {});
// Suppress logger.warn for error tests
vi.spyOn(logger, "warn").mockImplementation(() => {});

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain type safety and adhere to the repository's TypeScript guidelines, please provide an explicit return type for the mock implementation.

Suggested change
vi.spyOn(logger, "warn").mockImplementation(() => {});
vi.spyOn(logger, "warn").mockImplementation((): void => {});
References
  1. In TypeScript, ensure functions and mock implementations have explicit return types and use async functions for mocks returning Promises to maintain type safety and readability.

});

afterEach(() => {
Expand Down Expand Up @@ -124,9 +125,9 @@ describe("useThemeColor", () => {
expect(mockGetColorAsync).toHaveBeenCalled();
});

// Check that console.warn was called
// Check that logger.warn was called
await waitFor(() => {
expect(console.warn).toHaveBeenCalledWith(
expect(logger.warn).toHaveBeenCalledWith(
"Failed to extract color from avatar, keeping fallback color.",
error
);
Expand Down
3 changes: 2 additions & 1 deletion src/hooks/useThemeColor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useEffect } from "react";
import { FastAverageColor } from "fast-average-color";
import { logger } from "@/lib/logger";
import { adjustAccentColor } from "@/lib/color";

function applyColor(color: string | [number, number, number]) {
Expand Down Expand Up @@ -47,7 +48,7 @@ export function useThemeColor({ avatarUrl, topLanguageColor }: UseThemeColorOpti
}
})
.catch((e) => {
console.warn("Failed to extract color from avatar, keeping fallback color.", e);
logger.warn("Failed to extract color from avatar, keeping fallback color.", e);
});
}

Expand Down
Loading