Skip to content

feat(tui): replace [x] completion marker with [✓] across all sidebar panels#1935

Open
IIzzaya wants to merge 1 commit into
Hmbown:mainfrom
IIzzaya:izaya
Open

feat(tui): replace [x] completion marker with [✓] across all sidebar panels#1935
IIzzaya wants to merge 1 commit into
Hmbown:mainfrom
IIzzaya:izaya

Conversation

@IIzzaya
Copy link
Copy Markdown

@IIzzaya IIzzaya commented May 23, 2026

Summary

In tui mode, replace [x] completion marker with [✓] across all sidebar panels (more Chinese style lol)

image

Testing

  • cargo test --all-features
  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@weikengchen
Copy link
Copy Markdown

:) this sounds like a config option thing as github uses [x] (in Markdown), but I think that is due to historical reason because x is ASCII and ✓ is not.

But ✓ does look better.

@IIzzaya IIzzaya changed the title feat(tui): replace [x] completion marker with [✓] across all panels feat(tui): replace [x] completion marker with [✓] across sidebar panels May 23, 2026
@IIzzaya IIzzaya changed the title feat(tui): replace [x] completion marker with [✓] across sidebar panels feat(tui): replace [x] completion marker with [✓] across all sidebar panels May 23, 2026
@Hmbown
Copy link
Copy Markdown
Owner

Hmbown commented May 24, 2026

Thanks for the visual polish PR. The idea is understandable, and the screenshot makes the intent clear, but I am leaving it out of v0.8.42 because this is a product/style decision rather than a stabilization fix.

I agree with the comment that this may want to be a design/config decision instead of a blanket replacement, especially because [x] is ASCII/Markdown-familiar while the check mark reads better visually. Routing this to a later presence/UI pass rather than closing it.

@Hmbown Hmbown added this to the v0.8.48 milestone May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants