Skip to content

feat(pricing): make DeepSeek V4 Pro 75% discount permanent#1937

Open
Colorful-glassblock wants to merge 9 commits into
Hmbown:mainfrom
Colorful-glassblock:patch-1
Open

feat(pricing): make DeepSeek V4 Pro 75% discount permanent#1937
Colorful-glassblock wants to merge 9 commits into
Hmbown:mainfrom
Colorful-glassblock:patch-1

Conversation

@Colorful-glassblock
Copy link
Copy Markdown

@Colorful-glassblock Colorful-glassblock commented May 23, 2026

Summary

Removed the V4 Pro discount expiry logic in the TUI cost estimator so the 75% discount is treated as permanent, matching the updated official pricing.

Testing

  • cargo test --all-features
  • cargo fmt --all -- --check
  • cargo clippy --all-targets --all-features

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to reflect that the 75% discount for DeepSeek Pro is now permanent. Feedback indicates that the TUI's internal pricing logic and associated tests in crates/tui/src/pricing.rs must be updated to remove the expiration logic, and localized README files should be synchronized. Additionally, a suggestion was made to use a language-neutral URL for the pricing link in the English documentation.

Comment thread README.md Outdated
Legacy aliases `deepseek-chat` / `deepseek-reasoner` map to `deepseek-v4-flash` and retire after July 24, 2026. NVIDIA NIM variants use your NVIDIA account terms.

*DeepSeek Pro rates currently reflect a limited-time 75% discount, which remains valid until 15:59 UTC on 31 May 2026. After that time, the TUI cost estimator will revert to the base Pro rates.*
*DeepSeek Pro rates now reflect a permanent 75% discount. The TUI cost estimator will continue to display these permanently discounted Pro rates.*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The documentation update indicates that the 75% discount is now permanent. However, the TUI's cost calculation logic in crates/tui/src/pricing.rs still relies on v4_pro_discount_ends_at() (set to 2026-05-31) to determine when to revert to base rates. To prevent the TUI from displaying incorrect prices after that date, the logic in pricing.rs and its associated tests (e.g., v4_pro_returns_to_base_rates_after_discount_expiry) should be updated. Additionally, README.zh-CN.md and README.ja-JP.md should be synchronized with these changes to maintain consistency across all localized documentation.

Comment thread README.md Outdated
> [!Note]
> For the latest DeepSeek-V4-Pro pricing, including the current 75% discount valid until 15:59 UTC on 31 May 2026, please consult the official [DeepSeek pricing page](https://api-docs.deepseek.com/zh-cn/quick_start/pricing). All rates listed in the README correspond to the officially published values.

> DeepSeek-V4-Pro was previously offered at a 75% discount originally scheduled to end at 15:59 UTC on 31 May 2026. This discount has now been made permanent. For the latest pricing, please consult the official [DeepSeek pricing page](https://api-docs.deepseek.com/zh-cn/quick_start/pricing). All rates listed in the README correspond to the officially published values.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In the English README, it is preferable to link to the language-neutral or English version of the pricing page rather than the zh-cn specific one.

Suggested change
> DeepSeek-V4-Pro was previously offered at a 75% discount originally scheduled to end at 15:59 UTC on 31 May 2026. This discount has now been made permanent. For the latest pricing, please consult the official [DeepSeek pricing page](https://api-docs.deepseek.com/zh-cn/quick_start/pricing). All rates listed in the README correspond to the officially published values.
> DeepSeek-V4-Pro was previously offered at a 75% discount originally scheduled to end at 15:59 UTC on 31 May 2026. This discount has now been made permanent. For the latest pricing, please consult the official [DeepSeek pricing page](https://api-docs.deepseek.com/quick_start/pricing). All rates listed in the README correspond to the officially published values.

更新 DeepSeek Pro 的定价信息为永久 75% 折扣,并调整相关说明。
Updated pricing information for DeepSeek Pro to reflect permanent discount.
Updated pricing information for DeepSeek Pro to reflect permanent 75% discount and adjusted note regarding discount expiration.
@Colorful-glassblock
Copy link
Copy Markdown
Author

Windows test failure (cache_inspect_reports_tool_result_budget_metadata) is a pre-existing flaky test unrelated to this PR. The failure is in crates/tui/src/client/chat.rs:3000 — the dedup ref exceeded the 300-char budget because SHA spillover persistence likely failed on the Windows runner, causing the compactor to inline the full 14k-char tool result. This PR only touches crates/tui/src/pricing.rs and docs.

@Colorful-glassblock Colorful-glassblock changed the title docs: update Pro pricing to reflect permanent 75% discount feat(pricing): make DeepSeek V4 Pro 75% discount permanent May 23, 2026
@weikengchen
Copy link
Copy Markdown

I think it has overlapping with #1932 on the README side, but the TUI cost estimator needs to remove the end-time thing.

@Colorful-glassblock
Copy link
Copy Markdown
Author

@weikengchen Thanks for the heads-up! I'll drop the README changes from this PR to avoid overlapping with #1932. Appreciate you catching that — this PR will focus solely on the pricing.rs TUI cost estimator change (removing the discount end-time logic).

Comment thread crates/tui/src/pricing.rs
@@ -1,8 +1,8 @@
//! Cost estimation for DeepSeek API usage.
//!
//! Pricing based on DeepSeek's published rates (per million tokens).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/tui/src/pricing.rs

@Hmbown
Copy link
Copy Markdown
Owner

Hmbown commented May 24, 2026

Thanks for tightening the scope after the README overlap was pointed out. I am not merging pricing changes in v0.8.42 without a fresh check against the official DeepSeek pricing source on the exact day we land it.

For the next pass, please keep this PR limited to crates/tui/src/pricing.rs plus tests around the cost estimator. Maintainers should verify current official pricing first, then update docs/changelog from that source rather than relying on issue/PR text.

@Hmbown Hmbown added this to the v0.8.48 milestone May 24, 2026
@Colorful-glassblock
Copy link
Copy Markdown
Author

Screenshot_20260525_071859_com android chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants