feat: upgrade to ahbicht v2.0.0, remove inject dependency#270
Merged
feat: upgrade to ahbicht v2.0.0, remove inject dependency#270
Conversation
- Remove inject, EvaluatableDataProvider, TokenLogicProvider, SingletonTokenLogicProvider, create_content_evaluation_result_based_evaluators imports from expression_view.py - Remove _setup_weird_ahbicht_dependency_injection() function entirely - Update is_valid_expression call to use new format params instead of setter callback - Bump ahbicht dep to >=2.0.0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove unused AhbContext import - Fix unbound is_valid variable in except branch - Pass actual format/version from row data instead of hardcoding UTILMD Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python-injectusage fromexpression_view.py_setup_weird_ahbicht_dependency_injection()function entirelyis_valid_expressioncall to use new format params (v2.0.0 API)>=1.0.0,<2to>=2.0.0What was removed
import injectEvaluatableDataProvider,TokenLogicProvider,SingletonTokenLogicProviderimportscreate_content_evaluation_result_based_evaluatorsimport_content_evaluation_resultContextVar_get_evaluatable_data()function_setup_weird_ahbicht_dependency_injection()functionWhat changed
is_valid_expression(expression, _content_evaluation_result.set)→is_valid_expression(expression, EdifactFormat.UTILMD, EdifactFormatVersion.FV2504)See ahbicht v2.0.0 migration guide.
🤖 Generated with Claude Code