fix(llm): enforce max_retries cap on the unbounded retry loop#165
Open
lfnothias wants to merge 1 commit into
Open
fix(llm): enforce max_retries cap on the unbounded retry loop#165lfnothias wants to merge 1 commit into
lfnothias wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
LLMProvider.__call__retries in awhile Trueloop.self.max_retriesis set in__init__but never read, so a persistently failing provider (timeout, overload, rate limit) retries indefinitely, re-sending the full prompt each time — unbounded latency, and unbounded spend where partial output is billed. Both retryable paths now raise once the attempts reachself.max_retries. The context-window path keeps its own independent cap.Not changed
max_retriesstays at 3. The success path and non-retryable errors are unaffected; a non-retryable error is still raised on the first attempt. The only change in behaviour is that a call which previously could not terminate now does.Tests
tests/llm_provider_test.py: a persistent retryable error and repeated timeouts each raise aftermax_retries + 1attempts; a non-retryable error raises on the first attempt. The network call and the sleep are mocked. Full suite: 198 passed, 4 skipped.