Add APA DOCX manuscript export with reference deduplication#20
Closed
matrixflora wants to merge 1 commit into
Closed
Add APA DOCX manuscript export with reference deduplication#20matrixflora wants to merge 1 commit into
matrixflora wants to merge 1 commit into
Conversation
Collaborator
|
Blocking review — not mergeable as-is, and it conflicts with the "stay generalizable" goal:
Happy to rework this into an opt-in, optional-extra, tested exporter (matching the pattern used elsewhere). Converting to draft until then. |
1 task
Collaborator
|
Superseded by #24, which reworks this into a safe, generalizable form: opt-in (off by default) via |
lfnothias
added a commit
that referenced
this pull request
Jun 19, 2026
Generalizable rework of the approach in #20 (closed as draft): - OFF by default via config.rag_modes.agentic.export_apa_docx (+ _dir). - python-docx is an optional [docx] extra (uv sync --extra docx), imported lazily; absent extra raises a clear ImportError, swallowed off the answer path. - Exporter tolerates Paper objects, dicts, and Author objects/strings (the original treated papers/authors as dicts/strings and silently failed). - No debug prints; export failures never break the answer; references deduped. - Hermetic tests: APA formatting, config default-off, disabled-helper no-op, and a real .docx write (skipped without the extra). Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
uv run pytestuv run ruff check src/ tests/uv run mypy src/Test plan
Related issues