Skip to content

Set default window size sensibly#87

Merged
MikeMcQuaid merged 1 commit into
mainfrom
fix-window-size-again
Jul 9, 2026
Merged

Set default window size sensibly#87
MikeMcQuaid merged 1 commit into
mainfrom
fix-window-size-again

Conversation

@graeme

@graeme graeme commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

PR: Set default window size to 1000×650

Summary

The default window size was previously set to the minimum (820px wide), making the app feel cramped on first launch. This sets a more comfortable default of 1000×650.

Changes

  • BrewSpacing.swift: Added defaultWindowWidth (1000) and defaultWindowHeight (650) constants to BrewLayout
  • BrewApp.swift: Use new default constants instead of minimum constants for .defaultSize

Testing

  • Built and launched the app — window opens at the new default size

PR checklist

  • Have you followed this repository's contribution and workflow guidance?
  • Have you explained what changed and why this should land now?
  • Have you run relevant local checks for the changed scope?
  • Are changes scoped and free of unrelated modifications?

  • AI was used to generate or assist with generating this PR.
  • Claude drafted the PR description; changes were written and verified manually.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the app’s initial window size to be more comfortable on first launch, while preserving the existing minimum window constraints.

Changes:

  • Add BrewLayout.defaultWindowWidth / defaultWindowHeight constants (1000×650).
  • Switch BrewApp’s .defaultSize to use the new default constants instead of the minimums.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Sources/BrewUIComponents/Theme/BrewSpacing.swift Adds new default window size layout constants alongside existing min-size tokens.
Homebrew/BrewApp.swift Uses the new default size constants for WindowGroup’s .defaultSize(...).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid merged commit c632e0e into main Jul 9, 2026
10 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-window-size-again branch July 9, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants