Error while adding index via migration#43
Open
stanneeru wants to merge 1 commit intoHornsAndHooves:masterfrom
Open
Error while adding index via migration#43stanneeru wants to merge 1 commit intoHornsAndHooves:masterfrom
stanneeru wants to merge 1 commit intoHornsAndHooves:masterfrom
Conversation
Contributor
|
Thanks @stanneeru! This needs a test for each of these issues. The tests should fail without these changes and succeed with them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class was initialized but never defined
Chaining join method at line 246 was also causing error. Rails 6 has join by default so it needs to be removed here.