remove setCacheBeanMetadata to false, fix Spring @Order not work issue#603
Open
gejun123456 wants to merge 1 commit intoHotswapProjects:masterfrom
Open
remove setCacheBeanMetadata to false, fix Spring @Order not work issue#603gejun123456 wants to merge 1 commit intoHotswapProjects:masterfrom
gejun123456 wants to merge 1 commit intoHotswapProjects:masterfrom
Conversation
Contributor
Author
|
#461 related issue |
|
#458 seems to be related as well |
Contributor
|
@cvictory could you please check it? |
Contributor
|
Hi @gejun123456, just checking in — is this PR finished and tested? |
Contributor
Author
|
tested on my springboot enviroment, it works. may need more testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadata will be cleared after bean class change in SpringBeanReload invokeBeanFactoryPostProcessors(beanFactory);
in PostProcessorRegistrationDelegate it wil clear beanFactory.clearMetadataCache();
Not sure why it fixed the issue, but I haven't noticed any side effects. It would be great if someone could help review it. remove the code also can improve the performance, my project start time from 11 second to 9 seconds.
@cvictory @edudant @skybber help review thanks.