Exclude ByteBuddy classloaders from plugin class patching#672
Merged
skybber merged 1 commit intoHotswapProjects:masterfrom Feb 15, 2026
Merged
Exclude ByteBuddy classloaders from plugin class patching#672skybber merged 1 commit intoHotswapProjects:masterfrom
skybber merged 1 commit intoHotswapProjects:masterfrom
Conversation
ClassLoaderDefineClassPatcher.isPatchAvailable() did not exclude ByteBuddy's synthetic classloaders (ByteArrayClassLoader and JavaDispatcher$DynamicClassLoader). When Mockito's inline mock maker uses ByteBuddy to retransform classes, HotswapAgent would patch all plugin classes (including inner classes like VaadinPlugin$UpdateRoutesCommand) into ByteBuddy's classloaders. This causes IllegalAccessError because the plugin's inner classes end up in a different classloader than the plugin class itself: "failed to access class VaadinPlugin$UpdateRoutesCommand from class VaadinPlugin (VaadinPlugin$UpdateRoutesCommand is in unnamed module of loader ByteArrayClassLoader; VaadinPlugin is in unnamed module of loader 'app')" The fix adds ByteBuddy's ByteArrayClassLoader and JavaDispatcher$DynamicClassLoader to the exclusion list, matching the existing exclusions for JDK's DelegatingClassLoader. These synthetic classloaders should never receive HotswapAgent plugin class definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassLoaderDefineClassPatcher.isPatchAvailable() did not exclude ByteBuddy's synthetic classloaders (ByteArrayClassLoader and JavaDispatcher$DynamicClassLoader). When Mockito's inline mock maker uses ByteBuddy to retransform classes, HotswapAgent would patch all plugin classes (including inner classes like
VaadinPlugin$UpdateRoutesCommand) into ByteBuddy's classloaders.
This causes IllegalAccessError because the plugin's inner classes end up in a different classloader than the plugin class itself:
"failed to access class VaadinPlugin$UpdateRoutesCommand from class
VaadinPlugin (VaadinPlugin$UpdateRoutesCommand is in unnamed module
of loader ByteArrayClassLoader; VaadinPlugin is in unnamed module
of loader 'app')"
The fix adds ByteBuddy's ByteArrayClassLoader and
JavaDispatcher$DynamicClassLoader to the exclusion list, matching the existing exclusions for JDK's DelegatingClassLoader. These synthetic classloaders should never receive HotswapAgent plugin class definitions.
Fixes #671