Skip to content

fix redundant empty str in chunks #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mingregister wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

fix redundant empty str in chunks #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/_4_2_translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,12 @@ def split_chunks_by_chars(chunk_size, max_i):
sentence_count = 0
for sentence in sentences:
if len(chunk) + len(sentence + '\n') > chunk_size or sentence_count == max_i:
chunks.append(chunk.strip())
Copy link
Copy Markdown
Author

@mingregister mingregister Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the first time, enter this loop, chunk is '', so chunks will append a redundant empty str

chunk = sentence + '\n'
sentence_count = 1
else:
chunk += sentence + '\n'
sentence_count += 1
chunks.append(chunk.strip())
chunks.append(chunk.strip())
return chunks

# Get context from surrounding chunks
Expand Down Expand Up @@ -109,4 +108,4 @@ def translate_all():
console.print("[bold green]✅ Translation completed and results saved.[/bold green]")

if __name__ == '__main__':
translate_all()
translate_all()