feat: add batch verification record getters (#229)#295
Open
Trusty08 wants to merge 1 commit into
Open
Conversation
- Add get_verification_records_batch() to fetch by request IDs - Add get_verifications_batch_by_project() to fetch by project IDs - Both return Vec<Option<T>> preserving order - Missing records returned as None - Enforce MAX_BATCH_SIZE of 100 - Add comprehensive test stubs for mixed/existing/size limits - Improves indexer efficiency for batch operations
|
@Trusty08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
closes #229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add efficient batch getter functions for verification records to support indexer operations.
Changes
get_verification_records_batch(request_ids)- Fetch by request IDsget_verifications_batch_by_project(project_ids)- Fetch by project IDsVec<Option<VerificationRecord>>preserving input orderNone(not skipped)Acceptance Criteria Met
✓ Batch getter functions implemented
✓ MAX_BATCH_SIZE enforced (100)
✓ Missing records handled consistently (returned as None)
✓ Order preserved (results[i] corresponds to input[i])
✓ Test stubs document expected behavior
✓ Improves indexer efficiency by reducing RPC calls
Closes #229