feat: region metadata, integrity hash, owner review guard, and event snapshot tests#296
Open
gidson5 wants to merge 1 commit into
Open
feat: region metadata, integrity hash, owner review guard, and event snapshot tests#296gidson5 wants to merge 1 commit into
gidson5 wants to merge 1 commit into
Conversation
…ent snapshot tests Closes HubDApp#238 Closes HubDApp#245 Closes HubDApp#250 Closes HubDApp#258 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@gidson5 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_project_region/get_project_region(owner-only setter; stored underExtensionKey::ProjectRegion).add_reviewnow returnsContractError::OwnerCannotReview(code 57) whenreviewer == project.owner.name|slug|category|descriptioncomputed on everyregister_projectandupdate_projectcall; stored underExtensionKey::ProjectIntegrityHashand exposed viaget_project_integrity_hash.snapshot_owner_cannot_review_own_projecttest. Newregion_and_integrity.rstest module validates Add Project Region Metadata #238 and Add Project Integrity Hash #250 behaviour.Closes
Closes #238
Closes #245
Closes #250
Closes #258
Test plan
snapshot_project_registered_event_shape— verifies event topics and payload fieldssnapshot_fee_set_event_shape— verifies fee config eventsnapshot_admin_added_and_removed_event_shape— verifies admin lifecycle eventssnapshot_verification_requested_and_approved_event_shape— verifies verification eventssnapshot_review_deleted_by_admin_event_shape— verifies admin moderation eventsnapshot_owner_cannot_review_own_project— owner review blockedtest_region_is_none_by_default/test_owner_can_set_and_get_region/test_owner_can_clear_region/test_non_owner_cannot_set_regiontest_integrity_hash_set_on_registration/test_integrity_hash_changes_on_update🤖 Generated with Claude Code