fix: cache github token and handle expiry for gitgo new#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Overview
the new command was opening the browser to ask for a token every single time. this fixes that by saving the token locally after the first time you paste it. it also catches expired tokens so you dont get stuck with a failing command.
Changes
gitgo new: saves the token togitgo.github-tokenin your git config so it reuses it next timegitgo new: catches 401 errors from github, deletes the dead token, and automatically asks for a new onegitgo new: opens the classic token page by default so you can select the no expiration optionutils/config.py: adds a silent flag toset_configso the raw token doesnt leak into the terminal outputHow to Test
pip install -e ".[dev]"gitgo new test-repo1and paste your token when it asksgitgo new test-repo2Checklist
CHANGELOG.mdunder the[Unreleased]sectionREADME.md(if I added or changed a command)