fix: prevent double git init in quickstart command#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Overview
fixed a bug where
gitgo newwas quietly skipping the initial commit and push step.init_operationwas callinggit init, and thenlink_corewas running it again.link_coresaw it was already a repo and wrongly assumed it was just connecting an existing project to a remote, so it skipped pushing the newly scaffolded files.Closes #
Changes
link.py: added analready_initializedparameter tolink_core. when true, it skips callinggit initand proceeds directly to creating the initial commit and pushing.new.py: updatednew_operationto passalready_initialized=Truewhen it callslink_core.test_new.py: updated the test assertions to expect the new parameter.CHANGELOG.md: added an entry documenting the bug fix under the unreleased section.How to Test
pip install -e ".[dev]"gitgo new test-app python -ppytest tests/test_new.py -vChecklist
CHANGELOG.mdunder the[Unreleased]sectionREADME.md(if I added or changed a command)