Conversation
- Task 001 -- Added config_dir: Option<PathBuf> field to Config struct (/Users/jonathan.hendler/personal/JACS/jacs/src/config/mod.rs). Field is #[serde(skip)], set automatically by Config::from_file(), used by load_by_config to
resolve storage paths correctly. 6 new tests.
- Task 002 -- Added Agent::from_config(config: Config, password: Option<&str>) constructor (/Users/jonathan.hendler/personal/JACS/jacs/src/agent/mod.rs). Named from_config (not load) to avoid collision with existing
Agent::load(&str). Extracted shared calculate_storage_root_and_normalize helper to eliminate ~100 lines of duplication. 4 new tests.
- Task 003 -- Deprecated load_config_12factor, load_config_12factor_optional, load_config_file_only with #[deprecated(since="0.9.8")] (/Users/jonathan.hendler/personal/JACS/jacs/src/config/mod.rs). Added #[allow(deprecated)] to all
internal callers.
Wave 2 (JACS callers) -- 4 tasks complete:
- Task 004 -- Migrated jacs-cli (/Users/jonathan.hendler/personal/JACS/jacs-cli/src/main.rs). Created load_agent_from_config helper. Replaced all 7 load_agent() calls and config read subcommand. Zero deprecated function usage.
- Task 005 -- Migrated binding-core (/Users/jonathan.hendler/personal/JACS/binding-core/src/lib.rs). load(), load_file_only(), load_with_info() now use Agent::from_config. Password passed directly, not via env var.
- Task 006 -- Blocked (depends on Task 009 removing last caller from haisdk).
- Task 007 -- Complete (transitive via Task 005, no code changes needed).
load_agent_from_config accepted agent_file as its first parameter but used it as a config path. When -a /path/to/agent.json was passed, it tried to parse the agent JSON as a jacs.config.json and failed. Replaced with load_agent() — no parameters, resolves config from JACS_CONFIG env / ./jacs.config.json, resolves password from CLI chain. load_agent_with_cli_dns_policy wraps it with DNS flag overrides. The --agent-file flag variables are kept (prefixed with _) for future use when agent-file loading is properly implemented as a post-init step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.