Conversation
- Rust (binding-core): 26/26 pass (10 new parity + adapter inventory tests) - Rust (jacs-cli): 11/11 pass (4 new CLI snapshot tests) - Python: 20/20 new parity tests pass - Node.js: 14/14 new parity tests pass (539 total, 3 failures are pre-existing) - Go: Compiles clean (runtime needs CGo library, pre-existing constraint) The 3 Node.js failures are pre-existing (2 MCP proxy tests + 1 signFileSync test), not related to this work. The unstaged changes are version bumps from 0.9.12 to 0.9.13 across all Cargo.toml/package.json/pyproject.toml files.
- method_parity.json (26 SimpleAgentWrapper methods) + tests in Python/Node/Go - Error kind fixture (13 variants) + tests in all bindings - Go MCP contract drift test (was the only binding missing one) - CLI commands fixture + Rust snapshot test - Adapter inventory fixture + Python/Node tests
│ Suite │ Pass │ Fail │ Notes │ ├───────────────┼───────────┼──────┼────────────────────────┤ │ binding-core │ 54+ │ 0 │ (waiting on bg task) │ ├───────────────┼───────────┼──────┼────────────────────────┤ │ jacs-cli │ 18 │ 0 │ 4 snapshot tests pass │ ├───────────────┼───────────┼──────┼────────────────────────┤ │ Python parity │ 26 │ 0 │ +2 from first round │ ├───────────────┼───────────┼──────┼────────────────────────┤ │ Node.js │ 539 │ 3 │ pre-existing failures │ ├───────────────┼───────────┼──────┼────────────────────────┤ │ Go │ vet clean │ 0 │ CGo runtime constraint │ └───────────────┴───────────┴──────┴────────────────────────┘ All parity enforcement work is complete across both rounds (original 12 tasks + 15 issues). Ready to commit.
…he one exception (designed for independent schema loading). #2 KeyStore::load_private() → LockedVec — Breaking trait change: - Added PartialEq, Eq, and cross-type PartialEq<Vec<u8>> to LockedVec - Changed trait signature from Result<Vec<u8>> to Result<LockedVec> - FsEncryptedStore: eliminated the intermediate copy (was: create LockedVec → copy to Vec → drop LockedVec → return Vec; now: create LockedVec → return it) - InMemoryKeyStore: returns a fresh LockedVec clone from the locked storage - Updated macro stores and one test call site (.as_ref() for sign_detached) - 35/35 keystore tests pass #4 update_task — Implemented using the update_document pattern: fetch existing task by key, apply caller's modifications, re-sign, version, persist, validate against taskschema. Added task update CLI subcommand with -k (task key) and -f (updated JSON file) args. Updated CLI fixture (29→30 commands) and alignment fixture (15→16 CLI-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.