Kk number formatting coverage#1808
Conversation
📝 WalkthroughWalkthroughThe .NET SDK version in ChangesSDK bump and Kazakh locale test expansion
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves Kazakh (kk) locale parity coverage by adding explicit assertions around stable number separators (decimal + grouping) in humanized byte sizes and metric formatting, and updates the repo’s pinned .NET SDK version.
Changes:
- Renamed the Kazakh number-formatting test and expanded it to validate decimal, thousands grouping (NBSP), and negative metric formatting outputs.
- Updated
global.jsonto pin a newer .NET 11 preview SDK version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Humanizer.Tests/Localisation/kk/KazakhLocaleParityTests.cs | Adds/renames a test to assert stable Kazakh decimal and grouping separators in ByteSize and metric formatting. |
| global.json | Bumps the pinned .NET SDK version to a newer .NET 11 preview build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Here is a checklist you should tick through before submitting a pull request:
mainbranch (more info below)fixes #<the issue number>build.cmdorbuild.ps1and ensure there are no test failures