Skip to content

Kk number formatting coverage#1808

Open
sigmade wants to merge 2 commits into
Humanizr:mainfrom
sigmade:kk-number-formatting-coverage
Open

Kk number formatting coverage#1808
sigmade wants to merge 2 commits into
Humanizr:mainfrom
sigmade:kk-number-formatting-coverage

Conversation

@sigmade

@sigmade sigmade commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

Copilot AI review requested due to automatic review settings June 29, 2026 06:58
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The .NET SDK version in global.json is bumped from 11.0.100-preview.3 to 11.0.100-preview.5.26302.115. A Kazakh locale test method is renamed and expanded with two additional assertions covering byte-size formatting and metric conversion.

Changes

SDK bump and Kazakh locale test expansion

Layer / File(s) Summary
SDK version and Kazakh test updates
global.json, tests/Humanizer.Tests/Localisation/kk/KazakhLocaleParityTests.cs
Pins SDK to 11.0.100-preview.5.26302.115; renames ByteSizeHumanize_UsesKazakhNumberFormatting to NumberFormatting_UsesStableKazakhSeparators and adds assertions for ByteSize.FromKilobytes(1234) and (-1234L).ToMetric(decimals: 1).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A hop, a skip, the SDK's new,
Preview five with a longer queue.
Kazakh tests now check a bit more—
Kilobytes, metrics, and non-breaking lore.
🐇 All is well on the number floor!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The PR description is a generic checklist and only loosely relates to the actual SDK and Kazakh formatting changes. Replace the checklist with a brief summary of the SDK update and Kazakh number-formatting test coverage added in this PR.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: added Kazakh number-formatting coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Kazakh (kk) locale parity coverage by adding explicit assertions around stable number separators (decimal + grouping) in humanized byte sizes and metric formatting, and updates the repo’s pinned .NET SDK version.

Changes:

  • Renamed the Kazakh number-formatting test and expanded it to validate decimal, thousands grouping (NBSP), and negative metric formatting outputs.
  • Updated global.json to pin a newer .NET 11 preview SDK version.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/Humanizer.Tests/Localisation/kk/KazakhLocaleParityTests.cs Adds/renames a test to assert stable Kazakh decimal and grouping separators in ByteSize and metric formatting.
global.json Bumps the pinned .NET SDK version to a newer .NET 11 preview build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants