fix(release): dispatch publish/homebrew instead of workflow_call (npm OIDC mismatch)#81
Merged
Merged
Conversation
… OIDC) The first v0.13.0 run created the GitHub Release but npm rejected the publish with its misleading E404: npm trusted publishing validates the OIDC token's top-level workflow file, which is release.yml when publish.yml runs via workflow_call — but the trusted publisher on npmjs.com is registered for publish.yml. release.yml now dispatches publish.yml and update-homebrew.yml on the tag ref via the workflow_dispatch API (allowed with GITHUB_TOKEN; the recursion block only suppresses event-triggered runs). Dispatched runs have publish.yml as their top-level workflow, so the OIDC claim matches the existing npm configuration and the manual re-run path keeps working unchanged. - release.yml: permissions actions:write (id-token no longer needed here), dispatch step after release creation - publish.yml: drop the now-unused workflow_call trigger - update-homebrew.yml: workflow_call -> workflow_dispatch (it already polls npm for up to 5 min, so dispatch order doesn't matter) - docs/releasing.md: document the dispatch architecture and both failure modes hit on the first tag run Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
I4cTime
added a commit
that referenced
this pull request
Jul 11, 2026
… OIDC) (#81) (#82) The first v0.13.0 run created the GitHub Release but npm rejected the publish with its misleading E404: npm trusted publishing validates the OIDC token's top-level workflow file, which is release.yml when publish.yml runs via workflow_call — but the trusted publisher on npmjs.com is registered for publish.yml. release.yml now dispatches publish.yml and update-homebrew.yml on the tag ref via the workflow_dispatch API (allowed with GITHUB_TOKEN; the recursion block only suppresses event-triggered runs). Dispatched runs have publish.yml as their top-level workflow, so the OIDC claim matches the existing npm configuration and the manual re-run path keeps working unchanged. - release.yml: permissions actions:write (id-token no longer needed here), dispatch step after release creation - publish.yml: drop the now-unused workflow_call trigger - update-homebrew.yml: workflow_call -> workflow_dispatch (it already polls npm for up to 5 min, so dispatch order doesn't matter) - docs/releasing.md: document the dispatch architecture and both failure modes hit on the first tag run Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second and final fix from the first live v0.13.0 tag run. The concurrency deadlock (#78) was fixed; the retry then created the GitHub Release but npm rejected the publish — trusted publishing validates the OIDC token's top-level workflow file, which is
release.ymlunderworkflow_call, while the npm trusted publisher is registered forpublish.yml(npm's misleadingE404, same signature as the v0.10.1 incident).Fix:
release.ymlnow dispatchespublish.ymlandupdate-homebrew.ymlon the tag ref. Explicitworkflow_dispatchAPI calls are allowed withGITHUB_TOKEN(recursion prevention only blocks event-triggered runs), and dispatched runs are top-level, so the OIDC claim matches the existing npm config. Homebrew already polls npm for up to 5 minutes, so dispatch ordering is safe.After this lands on develop → main, delete the v0.13.0 release + tag and re-push the tag to run the chain end-to-end.
Type
Checklist
docs/releasing.mdupdated with the dispatch architectureBreaking changes
None.
🤖 Generated with Claude Code