Skip to content

Add route_request dispatch coverage#689

Open
ChristianPavilonis wants to merge 2 commits into
mainfrom
test-route-request-dispatch-451
Open

Add route_request dispatch coverage#689
ChristianPavilonis wants to merge 2 commits into
mainfrom
test-route-request-dispatch-451

Conversation

@ChristianPavilonis
Copy link
Copy Markdown
Collaborator

Summary

  • Add focused Fastly adapter route_request dispatch coverage.
  • Cover static TSJS success and unknown bundle handling.
  • Cover public discovery and unauthenticated admin dispatch.
  • Cover auction dispatch through consent-dependent setup.
  • Cover unknown-route publisher fallback dispatch without configured consent persistence.

Closes #451

Tests

  • cargo test -p trusted-server-adapter-fastly route_tests -- --nocapture
  • cargo fmt --all -- --check
  • cargo test --workspace
  • cargo clippy --workspace --all-targets --all-features -- -D warnings

@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review May 13, 2026 19:06
Copy link
Copy Markdown
Collaborator

@prk-Jr prk-Jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR adds focused Fastly adapter coverage for route_request. The overall direction is useful, but one assertion currently does not prove the route branch it is intended to cover because another branch can produce the same failure status.

CI Status

  • cargo fmt: PASS
  • cargo test: PASS
  • vitest: PASS
  • integration tests: PASS
  • browser integration tests: PASS
  • CodeQL: PASS
  • analysis jobs: PASS

Comment thread crates/trusted-server-adapter-fastly/src/route_tests.rs
Comment thread crates/trusted-server-adapter-fastly/src/route_tests.rs Outdated
Comment thread crates/trusted-server-adapter-fastly/src/route_tests.rs
@ChristianPavilonis ChristianPavilonis requested a review from prk-Jr May 15, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration coverage for route_request dispatch behavior

2 participants