Skip to content

Fix Sourcepoint HTML asset rewriting #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChristianPavilonis wants to merge 2 commits into from
Closed

Fix Sourcepoint HTML asset rewriting #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574aa6a
Fix Sourcepoint HTML asset rewriting and debug banner tools
ChristianPavilonis Jun 22, 2026
f02cf02
Merge branch 'main' into fix/sourcepoint-html-asset-rewrite
ChristianPavilonis Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/js/lib/src/integrations/sourcepoint/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import { installSourcepointGuard } from './script_guard';
type SourcepointWindow = Window & {
__tsjs_sourcepoint?: {
rewriteSdk?: boolean;
debugForceBannerVisible?: boolean;

@aram356 aram356 Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 note — These two fields are added to the SourcepointWindow type and the Rust config script now serializes both into window.__tsjs_sourcepoint, but no TS code reads them — the only consumer (shouldInstallSourcepointGuard) reads rewriteSdk only. Both debug behaviors are implemented entirely by the Rust-injected inline scripts. Keeping the type in sync with the emitted JSON is defensible as documentation; flagging so it's a conscious choice rather than a leftover from a planned-but-unwired TS consumer.

debugClearStateOnLoad?: boolean;
Comment on lines +8 to +9

@prk-Jr prk-Jr Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 thinking — debugForceBannerVisible and debugClearStateOnLoad are added to the __tsjs_sourcepoint window type, but no TypeScript reads them — the entire debug behavior is implemented by the Rust-injected inline scripts. That's fine as config-shape documentation, but worth confirming it's intentional rather than a half-wired feature (e.g. behavior that was meant to live in script_guard.ts but ended up Rust-side). If they're purely documentation, a short comment saying so would prevent a future reader from assuming the TS layer consumes them.

};
};

Expand Down
Loading
Loading