Also build nested directories in build-all#175
Merged
SaschaSchwarze0 merged 1 commit intomainfrom Mar 27, 2025
Merged
Conversation
SaschaSchwarze0
force-pushed
the
sascha-build-nested-directories
branch
from
423b941 to
3f0bdd1
Compare
Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
SaschaSchwarze0
force-pushed
the
sascha-build-nested-directories
branch
from
3f0bdd1 to
df24eb2
Compare
reggeenr
approved these changes
Mar 27, 2025
| --build-source https://github.com/IBM/CodeEngine \ | ||
| --build-context-dir trusted-profiles/${PROGRAMMING_LANGUAGE} \ | ||
| --trusted-profiles-enabled true \ | ||
| --trusted-profiles-enabled=true \ |
Collaborator
There was a problem hiding this comment.
That is interesting. Is it by intention?
Member
Author
There was a problem hiding this comment.
Yes, it has to be there. Boolean flags require the = sign in the Go CLI libraries. Without it, it does not work.
Collaborator
There was a problem hiding this comment.
Aaah that I didn't know! Thanks for sharing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trusted profile sample is nested because it contains one directory per language. The build file in those directories was not getting picked up.