Merged
Conversation
Member
Author
|
@reggeenr Initial Pull request for the Fotobox |
reggeenr
requested changes
May 13, 2025
Collaborator
reggeenr
left a comment
reggeenr
left a comment
There was a problem hiding this comment.
Hi,
thanks for pulling together this PR.
I suggest to apply a spelling check for the Readme. Apart from that, it would be great if we could migrate the COS integration to make use Trusted Profiles. The trusted profile setup should be doable with terraform, too.
One thing that needs to get addressed before merging this one, is to adjust the dockerfile and make sure to not rely on Dockerhub and to use scratch images, if possible.
Signed-off-by: Luke Roy <luke.roy@ibm.com>
Signed-off-by: Luke Roy <luke.roy@ibm.com>
Sathvik-Allundi-IBM
force-pushed
the
fotobox
branch
from
5d47808 to
5828601
Compare
Signed-off-by: Luke Roy <luke.roy@ibm.com> Co-authored-by: Sathvik Allundi <sathvik.allundi007@ibm.com>
Signed-off-by: Luke Roy <luke.roy@ibm.com>
Signed-off-by: Luke Roy <luke.roy@ibm.com>
Sathvik-Allundi-IBM
force-pushed
the
fotobox
branch
from
5828601 to
d704cd6
Compare
Signed-off-by: sathvik-allundi007 <sathvik.allundi007@ibm.com>
Sathvik-Allundi-IBM
force-pushed
the
fotobox
branch
from
d704cd6 to
447ae18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial Pull request with the IBM Fotobox