Conversation
SaschaSchwarze0
requested changes
May 16, 2025
| ## Setting up an OIDC SSO configuration | ||
|
|
||
| ### Github.com OIDC SSO | ||
|
|
Member
There was a problem hiding this comment.
Here it makes sense to have some explanation around the scanario, something like.
One publicly available OIDC provider is GitHub. Users accessing your application will authenticate with their GitHub identity.
Collaborator
Author
There was a problem hiding this comment.
I added a few more sentences to make the reader aware on what happens in the section and the subsection. Thanks for pointing that out
auth-oidc-proxy/README.md
Outdated
| OIDC_PROVIDER_TOKEN_ENDPOINT=https://github.com/login/oauth/access_token | ||
| OIDC_PROVIDER_USERINFO_ENDPOINT=https://api.github.com/user | ||
| ``` | ||
| * To add authorization checks one can either check for a specific user property |
Collaborator
Author
There was a problem hiding this comment.
Good catch! I slightly adjusted the sentence
To add authorization checks, one can check for a specific user property
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
SaschaSchwarze0
requested changes
May 21, 2025
Member
SaschaSchwarze0
left a comment
SaschaSchwarze0
left a comment
There was a problem hiding this comment.
Please sign your commits.
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
SaschaSchwarze0
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following sample demonstrates an SSO proxy pattern implemented with OIDC