Skip to content

feat(perf): replace sqlalchmey.inspect with direct probe #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michael-johnston wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(perf): replace sqlalchmey.inspect with direct probe #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions orchestrator/metastore/sqlstore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,20 @@ def __new__(cls, project_context: ProjectContext) -> "SQLResourceStore":
f"Using cached table existence check result: tables_exist={tables_exist}"
)
else:
# Network query: check if tables exist
# Use a direct SQL query rather than sqlalchemy.inspect() to avoid
# the Inspector's internal connection overhead.
log.debug("Checking if 'resources' table exists (network query)...")
inspector = sqlalchemy.inspect(engine)
tables_exist = inspector.has_table("resources")
if project_context.metadataStore.scheme == "sqlite":
existence_query = sqlalchemy.text(
"SELECT 1 FROM sqlite_master WHERE type='table' AND name='resources'"
)
else:
existence_query = sqlalchemy.text(
"SELECT 1 FROM information_schema.tables"
" WHERE table_schema = DATABASE() AND table_name = 'resources' LIMIT 1"
)
with engine.connect() as conn:
tables_exist = conn.execute(existence_query).fetchone() is not None
log.debug(f"Table existence check complete: tables_exist={tables_exist}")
# Cache the result
_tables_exist_cache[cache_key] = tables_exist
Expand Down