fix(language): use structured output for LLM response parsing#92
Merged
Conversation
Replace fragile regex-chain extraction with JSON-schema
structured output (response_format) to reliably parse the
ISO 639-1 code from the LLM response.
- Add response_format with strict json_schema to force the
model to return {"code": "<iso-639-1>"}
- Validate the extracted code with re.fullmatch and LANGUAGE_MAP
- Fix docstring incorrectly claiming None for English
- Update tests to mock JSON responses and cover new edge cases
Signed-off-by: Jakub Walaszczyk <jwalaszc@redhat.com>
Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace fragile regex-chain extraction with JSON-schema structured output (response_format) to reliably parse the ISO 639-1 code from the LLM response.