feat: add tooltip element to the builder#246
Open
jz5426 wants to merge 24 commits into
Open
Conversation
👷 Deploy request for carbon-components-builder pending review.Visit the deploys page to approve it
|
jz5426
marked this pull request as ready for review
May 19, 2023 12:06
jz5426
changed the title
jz5426
changed the title
jz5426
force-pushed
the
dev.tooltip
branch
2 times, most recently
from
June 8, 2023 14:06
794108b to
da47417
Compare
zvonimirfras
requested changes
Jun 8, 2023
| <AComponent | ||
| componentObj={componentObj} | ||
| rejectDrop={true} | ||
| // className={css`position: relative; display: inline-flex`} |
| select={select} | ||
| remove={remove} | ||
| selected={selected}> | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
?
Also, if there's no children, it should be a self-closing tag, no? <Tooltip ... />
Comment on lines
+125
to
+126
| placement: 'top', | ||
| alignment: 'center', |
Member
There was a problem hiding this comment.
are these default values? if yes, we don't (shouldn't) need to specify them, if bloats the json.
| outputs: () => '', | ||
| imports: ['TooltipModule'], | ||
| code: ({ json }) => { | ||
| return `<div class="bx--tooltip__label"> |
Member
There was a problem hiding this comment.
can be inline (without the return statement)?
| react: { | ||
| imports: ['Tooltip'], | ||
| code: ({ json }) => { | ||
| return `<Tooltip |
Member
There was a problem hiding this comment.
can be inline (without the return statement)?
| return <Tooltip | ||
| description={state.description} | ||
| direction={state.placement ? state.placement : 'top'} | ||
| align={state.alignment ? state.alignment : 'center'} |
| } | ||
| return <Tooltip | ||
| description={state.description} | ||
| direction={state.placement ? state.placement : 'top'} |
Member
There was a problem hiding this comment.
Why is it "placement" if the property it's used for is "direction"?
Also, how will this change in v11?
added 6 commits
June 9, 2023 17:42
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Contributor
Author
|
Verified that the component features and export works. |
added 2 commits
June 3, 2024 17:21
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
zvonimirfras
requested changes
Jul 16, 2024
zvonimirfras
left a comment
zvonimirfras
left a comment
Member
There was a problem hiding this comment.
input and output names should be camelCase
| className={css`${styleObjectToString(componentObj.style)}`} | ||
| definition={componentObj.definition} | ||
| align={componentObj.alignment}> | ||
| {componentObj.description} |
Member
There was a problem hiding this comment.
In both frameworks description is a child, so why don't we do that here too? Meaning description wouldn't be part of the componentObj.description - instead we just let items render.
Contributor
Author
There was a problem hiding this comment.
we stick with support only text only for now
Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #132