slider component#258
Open
jz5426 wants to merge 27 commits into
Open
Conversation
✅ Deploy Preview for carbon-components-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jz5426
commented
Aug 11, 2023
jz5426
commented
Aug 11, 2023
jz5426
commented
Aug 11, 2023
jz5426
commented
Aug 11, 2023
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
zvonimirfras
requested changes
Aug 11, 2023
Signed-off-by: Max You <max.you@outlook.com>
zvonimirfras
requested changes
Aug 24, 2023
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
zvonimirfras
requested changes
Sep 7, 2023
zvonimirfras
left a comment
zvonimirfras
left a comment
Member
There was a problem hiding this comment.
- Text input shouldn't be focusable in the editor.
- the undefined
- Input should be "Theme", not "Light"
- as a dev, I'm not sure I'd do this here, and I also think it's redundant and you should be able to just pass in the variable as is, and if it's not light, the component will default to dark
- is there a "required" input/prop in both framework that we should add here for use in forms?
|
When I set the slider number for max does not chnage when sliding. It remains 1000. Warning: Failed prop type: Invalid prop react-jsx-dev-runtime.development.js:118 Thanks for investigating |
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Akshat55
requested changes
Sep 22, 2023
Akshat55
reviewed
Sep 22, 2023
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
zvonimirfras
requested changes
Jan 4, 2024
zvonimirfras
left a comment
zvonimirfras
left a comment
Member
There was a problem hiding this comment.
feels like package-lock shouldn't be updated
zvonimirfras
approved these changes
Jan 4, 2024
zvonimirfras
self-requested a review
January 4, 2024 21:44
zvonimirfras
requested changes
Jan 4, 2024
zvonimirfras
left a comment
zvonimirfras
left a comment
Member
There was a problem hiding this comment.
package-lock and build seems to error
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Contributor
Author
|
Verified that the component features and export works. |
1 similar comment
Contributor
Author
|
Verified that the component features and export works. |
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve for #152