Edit mode for fragment title aligned properly#284
Open
Madhura-saw wants to merge 3 commits into
Open
Conversation
👷 Deploy request for carbon-components-builder pending review.Visit the deploys page to approve it
|
Member
|
@Madhura-saw Could you please sign off your commits? You can do so with the following instrucitons:
|
Author
yeah sure |
Author
Member
Author
Member
Here's what git says https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Tickets & Documents
What type of PR is this? (check all that apply)
Scope
This PR fixes the edit mode of the fragment title where the title does not move down and the also title subheading is not shifted from its original place.
Implementation
Flex properties of title-subheading and fragment-title were changed in order to align everything properly.
No other changes.
Screenshots/Recordings/Diagrams:
Screen.Recording.2023-10-15.at.4.31.58.PM.mp4
How to test
Check the UI by clicking on the edit icon besides the title in new fragment.
[optional] To-do before merge
[optional] To-do after merge