feat: add file uploader as a fragment component#302
Open
jz5426 wants to merge 9 commits into
Open
Conversation
added 3 commits
March 6, 2024 22:16
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
👷 Deploy request for carbon-components-builder pending review.Visit the deploys page to approve it
|
added 2 commits
March 13, 2024 15:30
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Contributor
Author
|
Verified that the component features and export works. |
added 3 commits
April 19, 2024 12:23
Akshat55
changed the title
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
zvonimirfras
requested changes
Jul 16, 2024
Comment on lines
+10
to
+21
| acceptedFileFormat: string; | ||
| buttonKind: string; | ||
| buttonLabel: string; | ||
| labelTitle: string; | ||
| filenameStatus: string; | ||
| dragAndDroplabelText: string; | ||
| labelDescription: string; | ||
| iconDescription: string; | ||
| size: string; | ||
| multiple: boolean; | ||
| disabled: boolean; | ||
| dragAndDrop: boolean; |
Member
There was a problem hiding this comment.
some of these (maybe all?) should be optional
| ...commonSlots, | ||
| ...slotsDisabled, | ||
| multiple: 'boolean', | ||
| isMultiple: (state: FileUploaderState) => ({ |
| onChange={(event: any) => { | ||
| sendSignal(state.id, 'valueChange', [event.value], { ...state, value: event.value }); | ||
| }} | ||
| accept={state.acceptedFileFormat.split(',')} |
Member
There was a problem hiding this comment.
looks like acceptedFileFormat should be acceptedFileFormats and be a list of strings
| buttonLabel: 'string', | ||
| labelTitle: 'string', | ||
| filenameStatus: 'string', | ||
| dragAndDroplabelText: 'string', |
Member
There was a problem hiding this comment.
something's off about this
Comment on lines
+6
to
+7
| import { Checkbox, Dropdown, TextInput, FileUploaderDropContainer, FileUploader } from '@carbon/react'; | ||
| import { angularClassNamesFromComponentObj, nameStringToVariableString, reactClassNamesFromComponentObj } from '../helpers/tools'; |
Member
There was a problem hiding this comment.
looks like these would be better split into multiple lines to follow the style in other files
| ...selectedComponent, | ||
| iconDescription: event.currentTarget.value | ||
| })} /> | ||
| </> |
Member
There was a problem hiding this comment.
Something's off with the indentation here
Comment on lines
+192
to
+209
| componentObj.dragAndDrop ? <FileUploaderDropContainer | ||
| className={cx(preventCheckEventStyle, componentObj.cssClasses?.map((cc: any) => cc.id).join(' '))} | ||
| accept={acceptedFileFormat} | ||
| multiple={componentObj.multiple} | ||
| disabled={componentObj.disabled} | ||
| labelText={componentObj.dragAndDroplabelText} | ||
| tabIndex={0} /> : <FileUploader | ||
| className={cx(preventCheckEventStyle, componentObj.cssClasses?.map((cc: any) => cc.id).join(' '))} | ||
| accept={acceptedFileFormat} | ||
| buttonKind={componentObj.buttonKind} | ||
| buttonLabel={componentObj.buttonLabel} | ||
| filenameStatus={componentObj.filenameStatus} | ||
| iconDescription={componentObj.iconDescription} | ||
| labelDescription={componentObj.labelDescription} | ||
| labelTitle={componentObj.labelTitle} | ||
| multiple={componentObj.multiple} | ||
| disabled={componentObj.disabled} | ||
| size={componentObj.size} /> |
Member
There was a problem hiding this comment.
this should be more readable. Follow the style from the rest of the repo (as suggested above)
Comment on lines
+266
to
+268
| [disabled]="${nameStringToVariableString(json.codeContext?.name)}Disabled" | ||
| [size]="${nameStringToVariableString(json.codeContext?.name)}Size" | ||
| [disabled]="${nameStringToVariableString(json.codeContext?.name)}Disabled" |
| ${json.dragAndDrop ? `[dropText]="${nameStringToVariableString(json.codeContext?.name)}DropText"` : ''} | ||
| ${json.dragAndDrop ? '' : `[buttonText]="${nameStringToVariableString(json.codeContext?.name)}ButtonText"`} | ||
| ${json.dragAndDrop ? '' : `[buttonType]="${nameStringToVariableString(json.codeContext?.name)}ButtonType"`} | ||
| (filesChange)= ${nameStringToVariableString(json.codeContext?.name)}onDropped.emit($event)> |
Comment on lines
+290
to
+305
| code: ({ json }) => { | ||
| return `<ibm-file-uploader | ||
| ${angularClassNamesFromComponentObj(json)} | ||
| [title]="${nameStringToVariableString(json.codeContext?.name)}Title" | ||
| [description]="${nameStringToVariableString(json.codeContext?.name)}Description" | ||
| [accept]="${nameStringToVariableString(json.codeContext?.name)}Accept" | ||
| [multiple]="${nameStringToVariableString(json.codeContext?.name)}Multiple" | ||
| [disabled]="${nameStringToVariableString(json.codeContext?.name)}Disabled" | ||
| [size]="${nameStringToVariableString(json.codeContext?.name)}Size" | ||
| [disabled]="${nameStringToVariableString(json.codeContext?.name)}Disabled" | ||
| [drop]="${nameStringToVariableString(json.codeContext?.name)}Drop" | ||
| ${json.dragAndDrop ? `[dropText]="${nameStringToVariableString(json.codeContext?.name)}DropText"` : ''} | ||
| ${json.dragAndDrop ? '' : `[buttonText]="${nameStringToVariableString(json.codeContext?.name)}ButtonText"`} | ||
| ${json.dragAndDrop ? '' : `[buttonType]="${nameStringToVariableString(json.codeContext?.name)}ButtonType"`} | ||
| (filesChange)= ${nameStringToVariableString(json.codeContext?.name)}onDropped.emit($event)> | ||
| </ibm-file-uploader>`; |
Member
There was a problem hiding this comment.
indentation + it doesn't need the explicit return statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #184