Conversation
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
linter Signedoff-by: Angelo De Caro <adc@zurich.ibm.com> Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
ale-linux
reviewed
Mar 31, 2026
ale-linux
reviewed
Mar 31, 2026
ale-linux
left a comment
ale-linux
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Angelo, great patch! Are we actually testing the new methods though?
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
Member
Author
|
Thanks @ale-linux , comments addressed. |
Member
Author
|
Yes, @ale-linux , Curve#NewZrFromBigInt, Zr#BigInt, Curve#ModAddMul3 are all tested in math_test.go |
ale-linux
approved these changes
Mar 31, 2026
ale-linux
left a comment
ale-linux
left a comment
Collaborator
There was a problem hiding this comment.
Thanks - sorry for missing the tests, my bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the following: