fix(ping): use transport-level health check for SSE servers#242
Open
kimjune01 wants to merge 1 commit into
Open
fix(ping): use transport-level health check for SSE servers#242kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
Replace server.connected (static property) with tool_manager.check_server_health() which performs a real transport-level send_ping() across all transport types. Fixes IBM#203
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203
Why
mcp-cli pingcheckedserver.connected, a static property that reflectsinitial connection state. For SSE transports this was always stale — the
ping command reported "Connected" even when the server was unreachable,
or failed silently.
Changes
server.connectedwithtool_manager.check_server_health(),which calls
send_ping()on the actual transport. Works for stdio, SSE,and HTTP.
list.index()for server filtering.Tests
4443 passed, 12 skipped, 0 failures.