Skip to content

fix(Global Catalog): fix price field capitalization#265

Merged
padamstx merged 2 commits intoIBM:mainfrom
benbuchanan:main
Mar 13, 2025
Merged

fix(Global Catalog): fix price field capitalization#265
padamstx merged 2 commits intoIBM:mainfrom
benbuchanan:main

Conversation

@benbuchanan
Copy link
Copy Markdown
Contributor

PR summary

Regen after api definition fixes like Price to price, include url field for object update, and support deployment_region query param

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Fixes object update and price field syntax

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration tests

[INFO] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.30 s -- in com.ibm.cloud.platform_services.global_catalog.v1.GlobalCatalogIT

Example tests

No errors above
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18.822 s
[INFO] Finished at: 2025-03-13T10:01:13-04:00
[INFO] ------------------------------------------------------------------------

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 13, 2025

CLA assistant check
All committers have signed the CLA.

@benbuchanan benbuchanan requested a review from padamstx March 13, 2025 15:07
@padamstx padamstx self-assigned this Mar 13, 2025
@padamstx padamstx changed the title fix(GlobalCatalog): regen after api def fixes fix(Global Catalog): fix price field capitalization Mar 13, 2025
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a question about the removal of the example code fragment for the getPricing() operation.

Signed-off-by: Ben Buchanan <buchanan@ibm.com>
Copy link
Copy Markdown
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 6cfe485 into IBM:main Mar 13, 2025
6 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 13, 2025
## [0.61.1](0.61.0...0.61.1) (2025-03-13)

### Bug Fixes

* **Global Catalog:** fix price field capitalization ([#265](#265)) ([6cfe485](6cfe485))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.61.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants