Skip to content

feat(IAM Identity): adding serviceId Groups API#274

Merged
pyrooka merged 2 commits intomainfrom
iam-identity-serviceIdGroups
Jul 18, 2025
Merged

feat(IAM Identity): adding serviceId Groups API#274
pyrooka merged 2 commits intomainfrom
iam-identity-serviceIdGroups

Conversation

@pooraniss-ibm
Copy link
Copy Markdown
Member

@pooraniss-ibm pooraniss-ibm commented Jun 26, 2025 •
edited
Loading

PR summary

Includes serviceID Groups api
Trusted profile email field is added

changes in checkstyle.xml to increase file length and method length

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-serviceIdGroups branch from 0e07841 to b4f99bf Compare June 27, 2025 08:15
@pooraniss-ibm
Copy link
Copy Markdown
Member Author

pooraniss-ibm commented Jun 27, 2025 •
edited
Loading

Screenshot 2025-06-26 at 03 07 19 Screenshot 2025-06-26 at 03 07 40 the newly added code changes passng build, and tests and examples passing too

@pooraniss-ibm pooraniss-ibm requested a review from pyrooka July 3, 2025 09:06
pyrooka
pyrooka approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good!

@pyrooka
Copy link
Copy Markdown
Member

pyrooka commented Jul 3, 2025

@pooraniss-ibm FYI, I've updated this PR with the changes from the main.

pyrooka
pyrooka requested changes Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I've already approved this, but now as I am looking at the other PRs I noticed a little discrepancy. The updated integration tests and examples don't use the ETag value. Could you add it, just to make sure all SDKs are in sync?

@pooraniss-ibm
feat(IAM Identity): adding serviceId Groups API
7fc84b9 
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-serviceIdGroups branch from b7ddd21 to 7fc84b9 Compare July 11, 2025 13:11
@pooraniss-ibm
Copy link
Copy Markdown
Member Author

pooraniss-ibm commented Jul 11, 2025

I know I've already approved this, but now as I am looking at the other PRs I noticed a little discrepancy. The updated integration tests and examples don't use the ETag value. Could you add it, just to make sure all SDKs are in sync?

yup, nice catch, I have updated the etag in update call :)

@pooraniss-ibm pooraniss-ibm requested a review from pyrooka July 11, 2025 13:12
pyrooka
pyrooka approved these changes Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pyrooka pyrooka merged commit f05f3c5 into main Jul 18, 2025
10 checks passed
@pyrooka pyrooka deleted the iam-identity-serviceIdGroups branch July 18, 2025 09:20
ibm-devx-sdk pushed a commit that referenced this pull request Jul 18, 2025
@semantic-release-bot
chore(release): 0.68.0 release notes
1cd2a5c 
# [0.68.0](0.67.1...0.68.0) (2025-07-18)

### Features

* **IAM Identity:** adding serviceId Groups API ([#274](#274)) ([f05f3c5](f05f3c5))
@ibm-devx-sdk
Copy link
Copy Markdown
Contributor

ibm-devx-sdk commented Jul 18, 2025

🎉 This PR is included in version 0.68.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pooraniss-ibm @pyrooka @ibm-devx-sdk