feat(IAM Policy Management): add support for action control templates from IAM#289
Merged
feat(IAM Policy Management): add support for action control templates from IAM#289
Conversation
… from IAM Signed-off-by: Rajesh Pirati <rajesh.pirati@ibm.com>
Contributor
Author
|
integration test results Examples |
padamstx
suggested changes
May 5, 2025
Contributor
padamstx
left a comment
padamstx
left a comment
There was a problem hiding this comment.
Examples code is missing a test for one operation and the integration test code is missing a test for one operation as well.
| example_target_account_id = None | ||
| example_assignment_etag = None | ||
| example_account_settings_etag = None | ||
| example_action_control_template_id = None |
Contributor
There was a problem hiding this comment.
If you add links to your API definition to describe the inter-operation dependencies, then the SDK generator would be able to generate these local variables automatically and also emit the code to assign their values and to also use their value at the appropriate places.
Video tutorial: https://secure.video.ibm.com/channel/23887899/playlist/651457/video/133486086
| except ApiException as e: | ||
| pytest.fail(str(e)) | ||
|
|
||
| @needscredentials |
Contributor
There was a problem hiding this comment.
This file is missing a test for the delete_action_control_template_version operation.
| ) | ||
| assert response.get_status_code() == 204 | ||
|
|
||
| def test_45_list_policy_template_versions(self): |
Contributor
There was a problem hiding this comment.
typo in function name? doesn't match operation being tested
| assert result.external_account_identity_interaction.identity_types.service.state == "monitor" | ||
| assert result.external_account_identity_interaction.identity_types.service_id is not None | ||
| assert result.external_account_identity_interaction.identity_types.service_id.state == "monitor" | ||
|
|
Contributor
There was a problem hiding this comment.
Missing test for the get_action_control_template_assignment operation.
Contributor
Author
There was a problem hiding this comment.
adding now.. Thanks
Contributor
Author
|
Integration test results Examples |
…es based on review feedback Signed-off-by: Rajesh Pirati <rajesh.pirati@ibm.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
May 7, 2025
# [0.65.0](v0.64.0...v0.65.0) (2025-05-07) ### Features * **IAM Policy Management:** add support for action control templates from IAM ([#289](#289)) ([579ae95](579ae95))
|
🎉 This PR is included in version 0.65.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
Issue: https://github.ibm.com/IAM/AM-issues/issues/3395