feat(IAM Policy Management): Updated role template references changes and test cases#311
Closed
bbellamgari wants to merge 3 commits intomainfrom
Closed
feat(IAM Policy Management): Updated role template references changes and test cases#311bbellamgari wants to merge 3 commits intomainfrom
bbellamgari wants to merge 3 commits intomainfrom
Conversation
|
Bhavana Bellamgari seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bbellamgari
changed the title
Contributor
|
Code looks good, see comment on go-sdk-pr: I think you need the CLA check to recheck: #311 (comment) It is passing on goSDK so it should be passing here too. |
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
bbellamgari
force-pushed
the
gen_sdk_role_template_references
branch
from
fa7c2db to
7e655b7
Compare
Signed-off-by: Bhavana Bellamgari <Bhavana.Bellamgari@ibm.com>
Member
|
Closing in favor of #312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR includes changes for role_template_references changes for policy template creation.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Currently we do not support role_template_references in policy templates. With this new behaviour, we are adding that functionality
Does this PR introduce a breaking change?
Other information
https://github.ibm.com/IAM/AM-issues/issues/4045