Skip to content

adding support for GH Actions#587

Open
vijay-vin wants to merge 5 commits intoIBM:mainfrom
vijay-vin:jenkinsPR-preview
Open

adding support for GH Actions#587
vijay-vin wants to merge 5 commits intoIBM:mainfrom
vijay-vin:jenkinsPR-preview

Conversation

@vijay-vin
Copy link
Copy Markdown

@vijay-vin vijay-vin commented Apr 6, 2026

Added support for pr-preview GHA
Also fixed icr.io and registry.redhat.io podman login.
sending jenkins short job name as a parameter to queue_poller.sh script

@vijay-vin vijay-vin force-pushed the jenkinsPR-preview branch from 6fe8f62 to a31b404 Compare April 6, 2026 04:40
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
@vijay-vin
Copy link
Copy Markdown
Author

vijay-vin commented Apr 6, 2026

@adarshagrawal38 , @iv1111 I will add the GHA code for the pr-preview via another PR so that it is easy to test once this PR is merged.

adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
vijay-vin added 2 commits April 6, 2026 11:21
@vijay-vin
adding support for GH Actions
8398038 
Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>
@vijay-vin
Fixed the review comments
061dba8 
Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>
@vijay-vin vijay-vin force-pushed the jenkinsPR-preview branch from de1b59c to 061dba8 Compare April 6, 2026 16:22
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread hack/cicd/pr-preview/Jenkinsfile
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread pr-preview/Jenkinsfile Outdated
adarshagrawal38
adarshagrawal38 reviewed Apr 6, 2026
View reviewed changes
Comment thread hack/cicd/pr-preview/Jenkinsfile
@vijay-vin
Copy link
Copy Markdown
Author

vijay-vin commented Apr 7, 2026

@adarshagrawal38
I also noticed that I can refactor icrLogin and redHatRegistryLogin definitions into a single definition that can be used for any repo login. I will do the refactoring later, in a different PR. I want to get the current PR and the GHA PR done, so that we have something running on our main repo. Then I can focus on refactoring. Just wanted to let you know.

vijay-vin added 2 commits April 8, 2026 11:08
@vijay-vin
Fixing the review comments
054078d 
Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>
@vijay-vin
Removed the variable that is not needed
9e65ab2 
Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>
@adarshagrawal38
Copy link
Copy Markdown
Member

adarshagrawal38 commented Apr 8, 2026

@vijay-vin please move pr-preview folder to hack/cicd

adarshagrawal38
adarshagrawal38 reviewed Apr 9, 2026
View reviewed changes
Comment thread hack/cicd/pr-preview/Jenkinsfile
@vijay-vin
moving pr-preview to hack/cicd
3f2623c 
Signed-off-by: Vijayv <vijay.vinnakota@ibm.com>
@vijay-vin
Copy link
Copy Markdown
Author

vijay-vin commented Apr 9, 2026

Yes, moved pr-preview folder to hack/cicd

adarshagrawal38
adarshagrawal38 reviewed Apr 13, 2026
View reviewed changes
Comment thread hack/cicd/pr-preview/Jenkinsfile
}
// Start queue poller to detect and abort duplicate builds
withCredentials([usernamePassword(
credentialsId: 'jenkins-api',
Copy link
Copy Markdown
Member

@adarshagrawal38 adarshagrawal38 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the credential ID, this one is personal and will be removed.

Suggested change
credentialsId: 'jenkins-api',
credentialsId: 'FUN_API_KEY',

adarshagrawal38
adarshagrawal38 reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@adarshagrawal38 adarshagrawal38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc: @iv1111 PTAL for approval

@vijay-vin vijay-vin mentioned this pull request Apr 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adarshagrawal38 adarshagrawal38 adarshagrawal38 requested changes

@iv1111 iv1111 Awaiting requested review from iv1111

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vijay-vin @adarshagrawal38