fix(datashare-python): properly support document with absolute path#29
Merged
Merged
Conversation
ClemDoum
force-pushed
the
fix(datashare-python)/doc-absolute-path-support
branch
from
1a57fd0 to
c3d7c2c
Compare
ClemDoum
force-pushed
the
fix(datashare-python)/doc-absolute-path-support
branch
from
c3d7c2c to
9a4a6e1
Compare
ClemDoum
force-pushed
the
fix(datashare-python)/doc-absolute-path-support
branch
from
9a4a6e1 to
bdb27d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
When a DS
Documenthas an absolute path/some/path, when aFilesystemDocumentis created from it usingto_filesystemand when we then dolocatewith this filesystem document using aoriginal_rootthis results in only the doc absolute path without theoriginal_rootbase.This is because
Path("/base") / Path("/absolute") == Path("/absolute").See unitest of this PR to understand the failure.
Changes
datashare-pythonFixed
FilesystemDocumentsupport only relative paths as they are meant to hold path relatively to their locationDocument.to_filesystemto make sure theFilesystemDocumentis created with a relative path