Skip to content

feature(translation worker): worker docker images#33

Merged
ClemDoum merged 14 commits into
mainfrom
feature(translation-worker)/docker-images
May 11, 2026
Merged

feature(translation worker): worker docker images#33
ClemDoum merged 14 commits into
mainfrom
feature(translation-worker)/docker-images

Conversation

@ClemDoum
Copy link
Copy Markdown
Contributor

@ClemDoum ClemDoum commented Apr 30, 2026

Description

Creates 2 translation worker images (see here)

  • icij/translation-io-worker
  • icij/translation-inference-worker

Changes

Changed

  • made TranslationWorkerConfig inherit from WorkerConfig and handled config reading through dependency injection
  • updated sentence splitting functions to take a Sentencizer as input ((text: str) -> Iterable[str])) (instead of the full translation ensemble)
  • removed the resolve_language_alpha_code activity and handle conversion of language names into their language alpha2 code thanks to pydantic deserialization
  • move TranslationEnsemble to specific modules (objects module is mainly meant to help with serialization/deserialization)
  • refactored global imports into local imports to allow not installing heavy dependencies when not needed

@ClemDoum ClemDoum force-pushed the feature(translation-worker)/docker-images branch 4 times, most recently from 548e426 to f1d4afb Compare May 4, 2026 08:22
@ClemDoum ClemDoum changed the title Feature(translation worker)/docker images feature(translation worker): worker docker images May 4, 2026
@ClemDoum ClemDoum force-pushed the feature(translation-worker)/docker-images branch 4 times, most recently from 97b2213 to 3b025af Compare May 4, 2026 14:11
@ClemDoum
Copy link
Copy Markdown
Contributor Author

ClemDoum commented May 4, 2026

addresses #24
addresses #25

@ClemDoum ClemDoum marked this pull request as ready for review May 4, 2026 14:25
@ClemDoum ClemDoum self-assigned this May 4, 2026
@ClemDoum ClemDoum force-pushed the feature(translation-worker)/docker-images branch from 17fd013 to d64132f Compare May 5, 2026 14:33
@ClemDoum
Copy link
Copy Markdown
Contributor Author

ClemDoum commented May 5, 2026

On hold untils argostranslate accept to allow torch to be optional import: argosopentech/argos-translate#521

@ClemDoum ClemDoum force-pushed the feature(translation-worker)/docker-images branch 3 times, most recently from 2ab7d2e to 7d9d0b0 Compare May 11, 2026 13:10
@ClemDoum ClemDoum force-pushed the feature(translation-worker)/docker-images branch from 7d9d0b0 to 6a12248 Compare May 11, 2026 13:16
@ClemDoum ClemDoum merged commit 7cb6cd3 into main May 11, 2026
4 checks passed
@ClemDoum ClemDoum deleted the feature(translation-worker)/docker-images branch May 11, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant