feature: single workfloww worker#35
Merged
Merged
Conversation
…`--workflows` as well as `-a`/`--activity`
…kflows worker version
… asr or translation worker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds a single worker image to run all DS workflows.
In the current architecture each worker repository build its own temporal workflow worker image.
In practice this setup doesn't work properly, indeed to be responsive, each worker app needs to have the worflow worker up all the time (otherwise we need to wait for the elastic scaler to spawn a new workflow worker).
As the number of worker app grows this will imply that many workflow workers will be up all the time.
To avoid this, this PR builds a single workflows worker image to run all workflows in the same worker.
This way for all apps a single worker will be up all the time.