Use old verion (81.0.0) of setuptools#1003
Merged
james-strauss-uwa merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePins the setuptools version used in the Playwright GitHub Actions workflow to 81.0.0 to ensure a stable and reproducible environment during CI runs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If this older setuptools version is required due to a specific compatibility issue, consider adding a brief inline comment in the workflow explaining why 81.0.0 is pinned to help future maintainers avoid upgrading it accidentally.
- To keep dependency management centralized, you might want to move the setuptools pin into a shared constraints/requirements file and reference that from the workflow instead of hardcoding the version here.
- Check other CI workflows for setuptools usage and align them with this pin (or explicitly choose where to diverge) to avoid subtle environment differences across jobs.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If this older setuptools version is required due to a specific compatibility issue, consider adding a brief inline comment in the workflow explaining why 81.0.0 is pinned to help future maintainers avoid upgrading it accidentally.
- To keep dependency management centralized, you might want to move the setuptools pin into a shared constraints/requirements file and reference that from the workflow instead of hardcoding the version here.
- Check other CI workflows for setuptools usage and align them with this pin (or explicitly choose where to diverge) to avoid subtle environment differences across jobs.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI: