Open
Conversation
Collaborator
|
Removing that setting is fine, that was my mistake the fix all and individual fixing of issues in the modal on load are working great. Problems: there is no way to get back to the version of the error modal that displays both, errors in the graph and in the palettes. |
…graph into drawing order.
Eagle 1136
Html graph renderer construct
Remove the requirement for a 'dropclass' field on Constructs
…n is now stored in the graph modelData.
…left floating in empty space
Default value of settings were not reset for 'Student' or 'Component' mode
Make it hard to save a graph with no name (or a bad name)
Removed the 'Description' category from CategoryData.
Factored out some common validation code into a single function within Utils
…do function from taking users back to a previously loaded graph.
…lass of edges that can never be created, even if the user has set 'allow invalid edges' to true.
…ments etc. We don't want the fix function to delete all these, we should rely on the user to switch them input PythonApps
Add new 'Impossible' value to the Eagle.LinkValid enum
removed all d3 stuff except in npm node modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could you take a quick look at this. Sorry, its a large code change.
The major changes are to use a common interface (a modal previously used for displaying/fixing graph errors) for three purposes:
It's useful to enable the following settings:
And test:
Also please check that removing line 345 from src/Setting.ts is OK