Change to black hole growth during starbursts#7
Open
jordanrossiter wants to merge 2 commits intoICRAR:masterfrom
Open
Change to black hole growth during starbursts#7jordanrossiter wants to merge 2 commits intoICRAR:masterfrom
jordanrossiter wants to merge 2 commits intoICRAR:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The formula used to calculate black hole growth during starbursts does not depend on the mass of the black hole, meaning that galaxies with no black hole (in which case m_bh = 0) can spontaneously gain a low-mass black hole. These black holes are well below the seeding mass, and are ignored when plotting, so I think it would be better to not allow them to be created in the first place. This is done by checking if a galaxy actually has a black hole first, before then calculating its growth during starbursts as before.