Merged
Conversation
markfuge
requested changes
Feb 3, 2026
Member
There was a problem hiding this comment.
Thanks @g-braeunlich I think this is largely good, except I found a few things:
- The image is missing (i.e., img/problems/thermoelastic3d.png). Perhaps @gapaza can help you with this?
- The link to the problem is missing from the right side nav bar. Perhaps we can take an approach similar to HeatConduction where we have boht 2D and 3D problems?
Can @gapaza take a look as well on the technical side to make sure everything is correct and renders properly?
Contributor
|
Taking a look at this today! I will add both the docs and the image as requested. |
Contributor
|
Ok, I just added the image and modified the index.md file to include the thermoelastic3d documentation (I also made sure to use the correct docs(project) commit tag as we just discussed). I downloaded the documentation from the GitHub action as Mark showed me and everything looks ok to me. |
Collaborator
Author
|
Thanks a lot! |
markfuge
approved these changes
Feb 5, 2026
Member
markfuge
left a comment
There was a problem hiding this comment.
Yep approved. Merge when ready @g-braeunlich
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds docs for thermoelastic3d, which I missed in the previous PR
Type of change
Please delete options that are not relevant.
Checklist:
pre-commitchecks withpre-commit run --all-filesruff check .andruff formatmypy .Reviewer Checklist: