Skip to content

fix(photonics2d): provide default value for num_optimization_steps#225

Merged
mkeeler43 merged 1 commit intomainfrom
224-photonics2doptimize-raises-keyerror-num_optimization_steps-after-config-refactor
Mar 2, 2026
Merged

fix(photonics2d): provide default value for num_optimization_steps#225
mkeeler43 merged 1 commit intomainfrom
224-photonics2doptimize-raises-keyerror-num_optimization_steps-after-config-refactor

Conversation

@g-braeunlich
Copy link
Collaborator

@g-braeunlich g-braeunlich commented Feb 27, 2026

Description

Fixes #224

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have run ruff check . and ruff format
  • I have run mypy .
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Reviewer Checklist:

  • The content of this PR brings value to the community. It is not too specific to a particular use case.
  • The tests and checks pass (linting, formatting, type checking). For a new problem, double check the github actions workflow to ensure the problem is being tested.
  • The documentation is updated.
  • The code is understandable and commented. No large code blocks are left unexplained, no huge file. Can I read and understand the code easily?
  • There is no merge conflict.
  • The changes are not breaking the existing results (datasets, training curves, etc.). If they do, is there a good reason for it? And is the associated problem version bumped?
  • For a new problem, has the dataset been generated with our slurm script so we can re-generate it if needed? (This also ensures that the problem is running on the HPC.)
  • For bugfixes, it is a robust fix and not a hacky workaround.

@g-braeunlich g-braeunlich force-pushed the 224-photonics2doptimize-raises-keyerror-num_optimization_steps-after-config-refactor branch from 19355f3 to 32abd13 Compare February 27, 2026 10:40
@mkeeler43 mkeeler43 merged commit d529a4d into main Mar 2, 2026
14 checks passed
@mkeeler43 mkeeler43 deleted the 224-photonics2doptimize-raises-keyerror-num_optimization_steps-after-config-refactor branch March 2, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

photonics2d.optimize() raises KeyError: 'num_optimization_steps' after Config refactor

2 participants