Open
Conversation
Meowcaroni
reviewed
Mar 15, 2026
Comment on lines
+87
to
+91
| dma_desc_fetch u_desc_fetch (.*); | ||
| dma_xfer_engine u_xfer_engine (.*); | ||
| dma_axi_mux u_axi_mux (.*); | ||
| dma_irq_ctrl u_irq_ctrl (.*); | ||
| dma_status u_status (.*); |
Collaborator
There was a problem hiding this comment.
Please add full module definitions for these instances to ensure dma_controller works as expected.
Meowcaroni
reviewed
Mar 15, 2026
| logic [DATA_W-1:0] rom [0:2**ADDR_W-1]; | ||
|
|
||
| initial begin | ||
| $readmemh("boot_code.mem", rom); |
Collaborator
There was a problem hiding this comment.
Make sure this data file is specified somewhere, such as the BootROM one-pager.
Meowcaroni
requested changes
Mar 15, 2026
Collaborator
There was a problem hiding this comment.
@AirPodsRed Add one-pager for BootROM (+ SRAM Dualport and DMA Controller if available) to docs/ip-briefs
Good so far on the RTL side, just make sure to write those additional modules you've instantiated for dma_controller.sv later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added completed RTL files for boot_rom, boot_rom_tb, sram_dualport, dma_pkg controller and arbiter
Related Issue(s)
synthesis verification is complete for boot_rom and sram_dualport. I was unable to check if dma files could synthesis since im not at my computer(eda pg was n/a for dma files), I can check them when im back in town later this week. Although according to the team members who submitted them they synthesize, so they should be good.