Skip to content

Add Get PCI Devices for Windows and Linux, Rename White Color#38

Open
sjchoure wants to merge 7 commits into
IEEE-VIT:masterfrom
sjchoure:lspci-func
Open

Add Get PCI Devices for Windows and Linux, Rename White Color#38
sjchoure wants to merge 7 commits into
IEEE-VIT:masterfrom
sjchoure:lspci-func

Conversation

@sjchoure

@sjchoure sjchoure commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

Partially Fixes: ls* Family Issue

What's new

  • Added Get PCI Devices Function For Windows and Linux
  • Renamed White Color to match other colors name

Usage

To see the output of PCI Devices:
do as
./termiboard.exe -pci-devices

Reference Docs:

  1. For Windows: Win32_PNPEntity and to query it: StackExchange/wmi pkg

  2. For Linux: jaypipes/ghw pkg

@sjchoure sjchoure marked this pull request as draft October 2, 2020 15:39
@sjchoure sjchoure marked this pull request as ready for review October 2, 2020 15:47
@sjchoure sjchoure marked this pull request as draft October 2, 2020 16:01
@sjchoure sjchoure marked this pull request as ready for review October 2, 2020 16:04

@aryan9600 aryan9600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I was hoping we could better format the stdout, this take up my entire screen :(
What about formatting it into a sort of table to improve readability? @DarthBenro008

@DarthBenro008

Copy link
Copy Markdown
Member

I had to do some research, I feel this could be more optimised, we need to come up some kind of priority class to display only some devices info first, this full list could be a accessed by a separate flag command. @aryan9600 i don't think a table would help in listing out PCI devices.

@aryan9600

Copy link
Copy Markdown
Member

Yeah a verbose flag makes sense to me. Basically wanted to avoid the output taking up the entire screen xD

@DarthBenro008 DarthBenro008 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation looks good, we can separate it out to a new flag.

Comment thread go.mod Outdated
@sjchoure sjchoure changed the title Add Get PCI Devices, Add Bold Green Color, Rename White Color Add Get PCI Devices for Windows and Linux, Rename White Color Oct 4, 2020
@sjchoure

sjchoure commented Oct 4, 2020

Copy link
Copy Markdown
Contributor Author

@DarthBenro008 @aryan9600 Please review it, and let me know if there are any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants