Add Get PCI Devices for Windows and Linux, Rename White Color#38
Add Get PCI Devices for Windows and Linux, Rename White Color#38sjchoure wants to merge 7 commits into
Conversation
aryan9600
left a comment
There was a problem hiding this comment.
Nice PR! I was hoping we could better format the stdout, this take up my entire screen :(
What about formatting it into a sort of table to improve readability? @DarthBenro008
|
I had to do some research, I feel this could be more optimised, we need to come up some kind of priority class to display only some devices info first, this full list could be a accessed by a separate flag command. @aryan9600 i don't think a table would help in listing out PCI devices. |
|
Yeah a verbose flag makes sense to me. Basically wanted to avoid the output taking up the entire screen xD |
DarthBenro008
left a comment
There was a problem hiding this comment.
The current implementation looks good, we can separate it out to a new flag.
|
@DarthBenro008 @aryan9600 Please review it, and let me know if there are any changes. |
Partially Fixes: ls* Family Issue
What's new
Usage
To see the output of PCI Devices:
do as
./termiboard.exe -pci-devicesReference Docs:
For Windows: Win32_PNPEntity and to query it: StackExchange/wmi pkg
For Linux: jaypipes/ghw pkg