Open
Conversation
Atchferox
reviewed
May 7, 2026
This comment was marked as resolved.
This comment was marked as resolved.
publicJorn
previously requested changes
May 8, 2026
Collaborator
Author
|
Alright, thanks for the feedback everyone; message received 😅. I've removed all of the "fancy" stuff, and have just left the static translated page titles. I did look into how translating the actual url works, and its... not great. What do we think? Also too much for this PR? plugins: [
paraglideVitePlugin({
project: "./project.inlang",
outdir: "./src/lib/paraglide",
strategy: ["url", "localStorage", "baseLocale"],
emitTsDeclarations: true,
urlPatterns: [
{
pattern: "/login",
localized: [
["en-US", "/login"],
["nl-NL", "/inloggen"],
],
},
{
pattern: "/forgot-password",
localized: [
["en-US", "/forgot-password"],
["nl-NL", "/wachtwoord-vergeten"],
],
},
],
}),
] |
Atchferox
requested changes
May 8, 2026
Contributor
There was a problem hiding this comment.
I think we should gitignore the .claude folder, and place the claude.md in the project root.
Comment on lines
+22
to
+37
| urlPatterns: [ | ||
| { | ||
| pattern: "/login", | ||
| localized: [ | ||
| ["en-US", "/login"], | ||
| ["nl-NL", "/inloggen"], | ||
| ], | ||
| }, | ||
| { | ||
| pattern: "/forgot-password", | ||
| localized: [ | ||
| ["en-US", "/forgot-password"], | ||
| ["nl-NL", "/wachtwoord-vergeten"], | ||
| ], | ||
| }, | ||
| ], |
Contributor
There was a problem hiding this comment.
This feels like a lot to maintain, maybe we should do something with this https://inlang.com/m/gerre34r/library-inlang-paraglideJs/tanstack-router#typesafe-translated-pathnames
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48.
Replaces hook-based title management with TanStack Router's
head()API and adds full i18n URL routing.Page titles
Page titles are now set via
head()on each route and rendered by<HeadContent />in the root layout. AmakePageTitlehelper (src/lib/title.ts) appends· Templateto every title, with the app name and delimiter configurable at the top of that file.Localised URL segments
Auth routes are translated per locale via
urlPatternsin the Paraglide Vite plugin:nl-NLen-US/login/inloggen/login/forgot-password/wachtwoord-vergeten/forgot-passworddeLocalizeUrl/localizeUrlinrouter.tsxautomatically map these to TanStack Router's internal paths.Root route head
beforeLoadcallsshouldRedirect()to redirect first-time visitors to their locale-specific URL.head()injects<link rel="canonical">pointing to thenl-NL(base locale) version of every page.Visuals
Notice the tab is showing the English title, URL and content